Skip to content

Remove file method#2500

Merged
dblock merged 6 commits into
ruby-grape:masterfrom
ericproulx:remove_file_deprecation
Sep 26, 2024
Merged

Remove file method#2500
dblock merged 6 commits into
ruby-grape:masterfrom
ericproulx:remove_file_deprecation

Conversation

@ericproulx

Copy link
Copy Markdown
Contributor

This PR removes the deprecated file method.

@ericproulx ericproulx marked this pull request as ready for review September 25, 2024 16:34
@ericproulx ericproulx requested a review from dblock September 25, 2024 17:30
@dblock

dblock commented Sep 25, 2024

Copy link
Copy Markdown
Member

Which version did we deprecate this in? If it's < 2.x then let's delete. Otherwise I think we should have a policy of deprecating in one major and deleting in the next major.

@ericproulx

Copy link
Copy Markdown
Contributor Author

Which version did we deprecate this in? If it's < 2.x then let's delete. Otherwise I think we should have a policy of deprecating in one major and deleting in the next major.

1.4.0. It's been a while

@dblock dblock merged commit 75e8c5b into ruby-grape:master Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants