Remove unused Request::DEFAULT_PARAMS_BUILDER constant

[eriklovmo]

The constant was introduced in 45abe0d but is never referenced and hasn't been since its inception.

[grape-bot]

	1 Warning
⚠️	There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

[ericproulx]

The constant was introduced in 45abe0d but is never referenced and hasn't been since its inception.

So true, I was supposed to use it but I reused the Grape.config.param_builder. Thanks for pointing out

[eriklovmo]

Do we want a changelog entry for this?

[ericproulx]

Do we want a changelog entry for this?

Please, even though its seems insignificant.

[dblock]

This was shipped in a previous version? I think we want a CHANGELOG and UPGRADING that mentions the removal of the constant since it is public and could have been used.

[eriklovmo]

Do we want a changelog entry for this?

Please, even though its seems insignificant.

Updated the changelog in 8b09187. @ericproulx

This was shipped in a previous version? I think we want a CHANGELOG and UPGRADING that mentions the removal of the constant since it is public and could have been used.

The constant we're removing here was introduced after version 2.3.0, so it hasn’t been officially released yet. For that reason, I’m thinking we shouldn't mention it in the UPGRADING doc. @dblock

[dblock]

The constant we're removing here was introduced after version 2.3.0, so it hasn’t been officially released yet. For that reason, I’m thinking we shouldn't mention it in the UPGRADING doc. @dblock

Yep, but also NBD.