Refactor ParamsScope and Parameters DSL to use named kwargs#2663
Merged
Conversation
Danger ReportNo issues found. |
ericproulx
added a commit
that referenced
this pull request
Mar 7, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4fd625f to
04bf07c
Compare
Replace positional/hash-based method signatures with named keyword arguments throughout: ParamsScope#initialize, new_scope, new_lateral_scope, push_declared_params, validate_attributes, require_required_and_optional_fields, and require_optional_fields. Callers updated accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
04bf07c to
b676ed4
Compare
dblock
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParamsScopeandParametersDSLParamsScope#initializenow usesapi:, element: nil, element_renamed: nil, parent: nil, optional: false, type: nil, group: nil, dependent_on: nilnew_scope,new_lateral_scope,push_declared_params,validate_attributesall converted to named kwargsnew_scopefirst argument renamed fromattrstoelement— callers now passattrs.firstdirectly, removing the doubleattrs.firstlookup inside the methodnew_group_scopefirst argument renamed fromattrstogroup— callers now pass the group hash directly instead of wrapping it in an arrayrequire_required_and_optional_fieldsandrequire_optional_fieldsnow declareusing:, except: nilexplicitly instead of accepting an opaqueoptshash — callers pass only the relevant keyswithconverted from a positional hash to**optskeyword arguments — passing an explicit hash literalwith({...})will now raiseArgumentError(see UPGRADING.md)Benefits
🤖 Generated with Claude Code