Merged
Conversation
Member
|
Hmmm not sure where those CI failures are coming from. @davesims do they look familiar? |
|
@jch Nope, haven't seen that. ¯_(ツ)_/¯ |
lib/net/ldap.rb
Outdated
| return result | ||
| end | ||
| result = conn.bind(args[:auth] || @auth) | ||
| return result unless result.code == Net::LDAP::ResultCodeSuccess |
Collaborator
Collaborator
Fix the bug in ruby-ldap#278
Collaborator
Author
|
@satoryu - Yep, that fixed it. Sorry about that. |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 20, 2017
=== Net::LDAP 0.16.0
* Sasl fix {#281}[ruby-ldap/ruby-net-ldap#281]
* enable TLS hostname validation {#279}[ruby-ldap/ruby-net-ldap#279]
* update rubocop to 0.42.0 {#278}[ruby-ldap/ruby-net-ldap#278]
This was referenced Oct 14, 2019
This was referenced Nov 19, 2019
This was referenced Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Rubocop and fixes a small handful of cops & changes.
Style/TrailingCommagot broken up intoStyle/TrailingCommaInLiteralandStyle/TrailingCommaInArguments(see Style/TrailingComma cop removed in patch-level release rubocop/rubocop#2678)Style/SingleSpaceBeforeFirstArgwas renamedStyle/SpaceBeforeFirstArg(see [FEATURE REQUEST] Style/SingleSpaceBeforeFirstArg:AllowForAlignment rubocop/rubocop#2504 (comment))Style/SymbolProcandStyle/GuardClauseare fixed repo-wide, and the exceptions removed from.rubocop_todo.yaml/cc @jch @mtodd