Skip to content

simplify encoding logic: no more chomping required#362

Merged
HarlemSquirrel merged 1 commit into
ruby-ldap:masterfrom
pvdb:use_strict_encode64
Jul 6, 2020
Merged

simplify encoding logic: no more chomping required#362
HarlemSquirrel merged 1 commit into
ruby-ldap:masterfrom
pvdb:use_strict_encode64

Conversation

@pvdb

@pvdb pvdb commented Jul 6, 2020

Copy link
Copy Markdown

As per #326 (comment)

I think https://ruby-doc.org/stdlib/libdoc/base64/rdoc/Base64.html#method-i-strict_encode64 would make this even more simple and not require calling #chomp

All done now... test still pass! 👍

@HarlemSquirrel HarlemSquirrel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel merged commit e6b1312 into ruby-ldap:master Jul 6, 2020
@pvdb pvdb deleted the use_strict_encode64 branch July 6, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants