Fix compute_follow_kernel_items to properly index bool array per kernel#785
Open
ydah wants to merge 1 commit intoruby:masterfrom
Open
Fix compute_follow_kernel_items to properly index bool array per kernel#785ydah wants to merge 1 commit intoruby:masterfrom
ydah wants to merge 1 commit intoruby:masterfrom
Conversation
Each kernel was incorrectly mapped to the full `Bitmap.to_bool_array` result (`Array[bool]`) instead of its indexed value. Since arrays are always truthy in Ruby, `follow_kernel_items[goto][kernel]` evaluated to true for every kernel, making the filtering in `goto_follow_set` (Definition 3.39) and `lhs_contributions` (Definition 3.31) ineffective. The fix computes the bool array once and assigns each kernel its corresponding bool value via index, which also eliminates redundant `Bitmap.to_bool_array` calls (previously N calls per goto, now 1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where each kernel was mapped to the full
Bitmap.to_bool_arrayresult (Array[bool]) instead of its indexed bool value.Since arrays are always truthy in Ruby,
follow_kernel_items[goto][kernel]evaluated totruefor every kernel, making the filtering ingoto_follow_set(Definition 3.39) andlhs_contributions(Definition 3.31) ineffective.The fix computes the bool array once and assigns each kernel its corresponding value: