Skip to content

🐛 Fix SequenceSet#max(n) when cardinality < n <= size #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 1 commit into from
Dec 16, 2025
Merged

🐛 Fix SequenceSet#max(n) when cardinality < n <= size #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/net/imap/sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,11 @@ def disjoint?(other)
# Related: #min, #minmax, #slice
def max(count = nil, star: :*)
if count
slice(-[count, size].min..) || remain_frozen_empty
if cardinality <= count
frozen? ? self : dup
else
slice(-count..) || remain_frozen_empty
end
elsif (val = max_num)
val == STAR_INT ? star : val
end
Expand Down
9 changes: 9 additions & 0 deletions test/net/imap/test_sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,15 @@ def obj.to_sequence_set; 192_168.001_255 end
assert_equal SequenceSet["678"], SequenceSet["345,678"].max(1)
assert_equal SequenceSet["345,678"], SequenceSet["345,678"].max(222)
assert_equal SequenceSet.empty, SequenceSet.new.max(5)
# with different cardinality (150) vs size (200)
set = SequenceSet["101:200,51:150"]
assert_equal SequenceSet["52:200"], set.max(149)
assert_equal SequenceSet["51:200"], set.max(150)
assert_equal SequenceSet["51:200"], set.max(200)
# with different cardinality (2**32) vs count (2**32 - 1)
set = SequenceSet[1..]
assert_equal SequenceSet["2:*"], set.max(2**32 - 1)
assert_equal SequenceSet["1:*"], set.max(2**32)
end

test "#minmax" do
Expand Down