Skip to content

Update io.rbs#1399

Merged
soutaro merged 5 commits into
ruby:masterfrom
ParadoxV5:io-rbs
Aug 14, 2023
Merged

Update io.rbs#1399
soutaro merged 5 commits into
ruby:masterfrom
ParadoxV5:io-rbs

Conversation

@ParadoxV5
Copy link
Copy Markdown
Contributor

  • Fill in untyped as appropriate
    • Many of them are simply boolish or void
    • Patching in ::popen is my main motivation. Yes, it is ridiculous.
    • Copy-pasted kwargs for #initialize and ::open
  • Use nil rather than NilClass
  • Delete nonexistent methods #bytes, #chars, #codepoints and #lines
  • Actually make aliases aliases
  • Fill in arg names for arg0

* Fill in `untyped` as appropriate
  * Many of them are simply `boolish` or `void`
  * Patching in `::popen` is my main motivation. Yes, it is ridiculous.
  * Copy-pasted kwargs for `#initialize` and `::open`
* Use `nil` rather than `NilClass`
* Delete nonexistent methods `#bytes`, `#chars`, `#codepoints` and `#lines`
* Actually make `#each` an alias of `#each_line`
* Fill in arg names for `arg0`
Comment thread core/io.rbs Outdated
Copy link
Copy Markdown
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@soutaro soutaro enabled auto-merge August 14, 2023 08:10
@soutaro soutaro added this to the RBS 3.2 milestone Aug 14, 2023
@soutaro soutaro added this pull request to the merge queue Aug 14, 2023
Merged via the queue into ruby:master with commit 1b69015 Aug 14, 2023
@ParadoxV5 ParadoxV5 deleted the io-rbs branch August 14, 2023 18:31
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released PRs already included in the released version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants