ZJIT: Introduce SCRATCH2 for IncrCounter on arm64 #14367
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Max's suggestion at #14357 (comment).
Adding
SCRATCH2allowsarm64_emitto emitIncrCounterwithout relying onarm64_split, which letscompile_side_exitsremove thecfg!(target_arch = "aarch64")branch. I don't think takingOpnd::const_ptrinIncrCounteras Max suggested isn't worth it, which will duplicate more code inarm64_emit, so it still takesOpnd::Mem.It generally doesn't seem like a good idea to waste a register when you can save it with no run-time overhead, especially when it's for
--zjit-stats. But at the same time, it seems useful to remove an extra register pressure that the other architecture doesn't have for the same LIR instruction.x18is a platform register. Since we control the use of every register in JIT code, it seems safe to use it as an extra caller-saved register. We don't seem to have any more caller-saved registers.