(Wrong) fix for bundle lock edge case#7376
Closed
deivid-rodriguez wants to merge 1 commit intomasterfrom
Closed
Conversation
Bring lockfile up to date when `bundle lock --update foo --patch --strict` is given with an out of date lockfile.
deivid-rodriguez
changed the title
bundle lock edge casebundle lock edge case
4 tasks
Contributor
Author
|
I'm replacing this wrong approach with #7527. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The problem is #7369. However, after further thought I don't think this is a good solution and we should only aim to provide a better error message here.
What is your fix for the problem, implemented in this PR?
Bring lockfile up to date when
bundle lock --update foo --patch --strictis given with an out of date lockfile.I don't think we want to do that, really.
Make sure the following tasks are checked