Fix Bundler crashing when it tries to install plugin:#9335
Merged
Conversation
Edouard-chin
commented
Feb 16, 2026
| plugin_should_be_installed("foo") | ||
| end | ||
|
|
||
| it "respects bundler groups" do |
Member
Author
There was a problem hiding this comment.
Without the fix, this test just crashes
kou
approved these changes
Feb 17, 2026
| next if index.installed?(name) | ||
|
|
||
| spec = specs[name] | ||
| next if spec.nil? || index.installed?(name) |
Member
There was a problem hiding this comment.
It may be better that we have a comment when spec is nil.
- ### Problem Bundler crashes when a Gemfile contains a plugin and you try to run `bundle install` while setting the BUNDLE_WITHOUT=default value. ### Context Setting the BUNDLE_WITHOUT=default is something that some deployment tooling does like [shipit](https://github.com/Shopify/shipit-engine/blob/a24b9d8b1b777e22f05311705be7938a4823eee6/app/models/shipit/deploy_spec/bundler_discovery.rb#L6) The intent being to only install gems that are required to deploy the app (for instance ones that are inside a `group :deploy` block). ### Solution Bundler assume that all plugins inside the Gemfile will get installed, but don't take in consideration that a BUNDLE_WITHOUT may have affected this. So before registering a plugin, make sure it's actually in the `specs` object (meaning it was installed on disk).
Edouard-chin
force-pushed
the
ec-bundler-plugin-fix
branch
from
3a5ac2b to
b416a02
Compare
hsbt
added a commit
that referenced
this pull request
Feb 24, 2026
Fix Bundler crashing when it tries to install plugin: (cherry picked from commit faa64e2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Bundler crashes when a Gemfile contains a plugin and you try to run
bundle installwhile setting theBUNDLE_WITHOUT=defaultvalue.What is your fix for the problem, implemented in this PR?
Context
Setting the BUNDLE_WITHOUT=default is something that some deployment tooling does like shipit. The intent being to only install gems that are required to deploy the app (for instance ones that are inside a
group :deployblock).Solution
Bundler assume that all plugins inside the Gemfile will get installed, but don't take in consideration that a
BUNDLE_WITHOUTmay have affected this.So before registering a plugin, make sure it's actually in the
specsobject (meaning it was installed on disk).Make sure the following tasks are checked