Restore rb_sys dependency for Rust#9416
Conversation
There was a problem hiding this comment.
Pull request overview
Restores the rb_sys gem dependency in Bundler’s Rust gem scaffolding so the generated Rakefile (which requires rb_sys/extensiontask) works after bundle install, fixing LoadError failures when running tasks like bundle exec rake compile.
Changes:
- Add
rb_sysas a dependency in the Rustnewgemgemspec template. - Update
bundle gem --ext=rustspecs to assert the generated gemspec includesrb_sys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
bundler/spec/commands/newgem_spec.rb |
Updates Rust scaffold expectations to include an rb_sys dependency in the generated gemspec. |
bundler/lib/bundler/templates/newgem/newgem.gemspec.tt |
Adds rb_sys dependency when generating a gem with --ext=rust. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@gjtorikian @ianks What do you think of this proposal? I removed that depdendency at fb3f1fe. I understand that I no longer need |
|
As far as I understand, you need both the Ruby |
Restore rb_sys dependency for Rust (cherry picked from commit 3fbe199)
Restore rb_sys dependency for Rust (cherry picked from commit 3fbe199)
What was the end-user or developer problem that led to this PR?
After running
bundle gem --ext=rust my_gemandbundle install, I got an error when I runbundle exec rake compile(I followed oxidize.rb guide):What is your fix for the problem, implemented in this PR?
Revert #8455 partially. In that PR,
rb_syswas removed from the dependencies, but it seems to be unintended. Withoutrb_sys,rb_sys/extensiontaskcannot be loaded, so all rake commands cannot be run.Make sure the following tasks are checked