Fix incompatible function pointer type error with Xcode 26.5 beta#9453
Merged
Conversation
Xcode 26.5 beta ships a clang that promotes -Wincompatible-function-pointer-types to an error by default. The test's inline C extension defined `VALUE foo()` (taking no arguments) but passed it to `rb_define_global_function` which expects `VALUE (*)(VALUE)` through Ruby's RBIMPL_ANYARGS dispatch macro. Adding the `VALUE self` parameter fixes the signature mismatch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates an inline C extension used in Bundler’s git-source install specs to compile cleanly with Xcode 26.5 beta’s clang, which now errors on incompatible function-pointer types.
Changes:
- Fix the C function signature for a global Ruby function defined via
rb_define_global_functionby adding the requiredVALUE selfparameter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsbt
added a commit
that referenced
this pull request
Apr 7, 2026
Fix incompatible function pointer type error with Xcode 26.5 beta (cherry picked from commit d6116b7)
hsbt
added a commit
that referenced
this pull request
Apr 7, 2026
Fix incompatible function pointer type error with Xcode 26.5 beta (cherry picked from commit d6116b7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Xcode 26.5 beta ships a clang that promotes
-Wincompatible-function-pointer-typesto an error by default. The test's inline C extension definedVALUE foo()(taking no arguments) but passed it torb_define_global_functionwhich expectsVALUE (*)(VALUE)through Ruby'sRBIMPL_ANYARGSdispatch macro.What is your fix for the problem, implemented in this PR?
Adding the
VALUE selfparameter fixes the signature mismatch.Make sure the following tasks are checked