Skip to content

Speed up Set#flatten #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knu merged 1 commit into from
Nov 29, 2024
Merged

Speed up Set#flatten #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,16 +353,19 @@ def to_set(klass = Set, *args, &block)
klass.new(self, *args, &block)
end

def flatten_merge(set, seen = Set.new) # :nodoc:
def flatten_merge(set, seen = {}) # :nodoc:
set.each { |e|
if e.is_a?(Set)
if seen.include?(e_id = e.object_id)
case seen[e_id = e.object_id]
when true
raise ArgumentError, "tried to flatten recursive Set"
when false
next
end

seen.add(e_id)
seen[e_id] = true
flatten_merge(e, seen)
seen.delete(e_id)
seen[e_id] = false
else
add(e)
end
Expand Down