Skip to content

Add bytes processor#2008

Merged
deguif merged 3 commits into
ruflin:masterfrom
deguif:bytes-processor
Oct 29, 2021
Merged

Add bytes processor#2008
deguif merged 3 commits into
ruflin:masterfrom
deguif:bytes-processor

Conversation

@deguif

@deguif deguif commented Oct 28, 2021

Copy link
Copy Markdown
Collaborator

See #1812

@ruflin ruflin left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one nit.


namespace Elastica\Processor;

class BytesProcessor extends AbstractProcessor

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it, nice catch ;)

@deguif deguif merged commit 9bdb007 into ruflin:master Oct 29, 2021
@deguif deguif self-assigned this Dec 7, 2021
@deguif deguif mentioned this pull request Dec 9, 2021
15 tasks
@deguif deguif deleted the bytes-processor branch December 9, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants