feat(models): allow MODELS env to add new models, not just override #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, MODELS env var could only override models discovered from
OPENAI_BASE_URL. This change allows MODELS entries with explicit
endpoints to be added as new models when they don't match any
discovered model.
This enables configuring multiple LLM backends (e.g., NIM + FakeLLM)
from different endpoints without requiring a proxy or load balancer.
Example MODELS config for multiple backends:
[
{"id":"model-from-api1","name":"Model 1","endpoints":[{"type":"openai","baseURL":"http://api1/v1"}]},
{"id":"model-from-api2","name":"Model 2","endpoints":[{"type":"openai","baseURL":"http://api2/v1"}]}
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, MODELS env var could only override models discovered from OPENAI_BASE_URL. This change allows MODELS entries with explicit endpoints to be added as new models when they don't match any discovered model.
This enables configuring multiple LLM backends (e.g., NIM + FakeLLM) from different endpoints without requiring a proxy or load balancer.