Exit earlier when not overwriting output#1220
Merged
Merged
Conversation
Stop the program from running earlier in parse_cli() when not overwriting the output file, so that no Vapoursynth cache file is created in the case that no video encoding occurs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
+ Coverage 62.24% 62.26% +0.01%
==========================================
Files 23 23
Lines 7332 7333 +1
==========================================
+ Hits 4564 4566 +2
+ Misses 2768 2767 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Seems good. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop the program from running earlier in parse_cli() when not overwriting the output file, so that no Vapoursynth cache file is created in the case that no video encoding occurs
Incidentally, this also speeds up Av1an exiting when
-nis specified, even when the Vapoursynth cache file was already created (on Windows 11: ~90ms w/ this change, ~140ms on previous commit when the Vapoursynth cache file exists, even longer if the cache file doesn't exist)Fixes #1084