Skip to content

Exit earlier when not overwriting output#1220

Merged
shssoichiro merged 2 commits into
rust-av:masterfrom
woot000:early-exit
Mar 24, 2026
Merged

Exit earlier when not overwriting output#1220
shssoichiro merged 2 commits into
rust-av:masterfrom
woot000:early-exit

Conversation

@woot000

@woot000 woot000 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Stop the program from running earlier in parse_cli() when not overwriting the output file, so that no Vapoursynth cache file is created in the case that no video encoding occurs

Incidentally, this also speeds up Av1an exiting when -n is specified, even when the Vapoursynth cache file was already created (on Windows 11: ~90ms w/ this change, ~140ms on previous commit when the Vapoursynth cache file exists, even longer if the cache file doesn't exist)

Fixes #1084

Stop the program from running earlier in parse_cli() when not overwriting the output file, so that no Vapoursynth cache file is created in the case that no video encoding occurs
@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.26%. Comparing base (f6c37bd) to head (fbcbba5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
av1an/src/main.rs 25.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
+ Coverage   62.24%   62.26%   +0.01%     
==========================================
  Files          23       23              
  Lines        7332     7333       +1     
==========================================
+ Hits         4564     4566       +2     
+ Misses       2768     2767       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shssoichiro

Copy link
Copy Markdown
Member

Seems good. thanks!

@shssoichiro shssoichiro merged commit 7daa0c0 into rust-av:master Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vapoursynth cache file is always generated, even if -n is specified

2 participants