Convert to Edition 2018 --- contains #43#44
Closed
Ericson2314 wants to merge 4 commits into
Closed
Conversation
Use void::Void, which in uninhabited, to do this.
Contributor
|
Nack for now, should be included once the minimum rust version gets bumped again. |
Contributor
Author
|
The latest preference/decision (I'm not sure which) in #43 was to bump the MSRV, after which there is no reason not to do this. |
Merged
Member
|
We can close this one, edition 2018 bump was done in #57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#43 is not strictly needed, but it's nice to remove the
extern crateI had to add to that one in this.