Merged
Conversation
apoelstra
force-pushed
the
2025-07_ci-0.10
branch
from
35d584d to
64e8c85
Compare
sanket1729
approved these changes
Jul 4, 2025
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
utACK 64e8c85.
Fuzzer is still red because of some dependancy breakage in 10.x. But that is fine.
apoelstra
force-pushed
the
2025-07_ci-0.10
branch
from
7af8c03 to
6658545
Compare
Member
Author
|
lol now the fuzzer is actually failing. I guess I ought to fix that and do another release.. |
Member
Author
apoelstra
force-pushed
the
2025-07_ci-0.10
branch
from
6658545 to
32ea5da
Compare
apoelstra
force-pushed
the
2025-07_ci-0.10
branch
from
32ea5da to
2800fd5
Compare
Aside from being more future-proof, this also works with my local CI.
It may be that ubuntu-latest breaks us, but we're not doing anything particularly exotic so it seems unlikely. Meanwhile, our use of ubuntu-20.04 HAS broken us, because that runner is no longer supported. Meanwhile also update a bunch of our action versions to v4, since some of the v2s have become deprecated and removed. (Hopefully this won't happen very often.)
apoelstra
force-pushed
the
2025-07_ci-0.10
branch
from
2800fd5 to
722e867
Compare
Weird that this only has an effect on a couple files, which aren't checked in the Github CI. Same story with 12.x.
As in rust-bitcoin#835, I changed a test function that used 'A'..'Z' to use an inclusive range, which is behavior-changing, and changed the impl of OrdF64::partial_cmp to be correct. Everything else is just syntactic. I apologize for structuring this PR very differently from rust-bitcoin#835 so you can't really range-diff. I tried rebasing and there were so many conflicts that I simply redid the whole thing, and since I had some experience I made some different decisions about what order to take things in.
Mostly removing &s.
This was at 1.58 to handle honggfuzz breakage; apparently it has to be 1.65 now.
This results in fuzzer crash when trying compute the checksum in `Display` implemenation of Descriptor Backport of 60fde9e from rust-bitcoin#569.
apoelstra
force-pushed
the
2025-07_ci-0.10
branch
from
722e867 to
4842494
Compare
sanket1729
reviewed
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should get us green CI, and pins the nightly compiler version so that it stays green.