Conversation
This has more overhead as it has to track the UTF8 parse state to tell UTF8 continuations from single-byte control codes.
This will be one of the building blocks for `Stream`.
pksunkara
reviewed
Mar 8, 2023
c42d718 to
ea3c0d1
Compare
2 tasks
epage
added a commit
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step of #5.
This is only supporting
AlwaysAnsiandNeverand only using TTY and wincon information.Future work
Areas of uncertainty
always_ansicallwindows::enable_ansi_colors? Probably but then we'd need to make sure it doesn't get called twice in a rowIn doing this, I made
printlnbypass one of the common pitfalls for CLI authors: the panic on broken pipe. This will instead let the application keep printing which is a better default.Another CLI pitfall is the performance of using the non-locked version. This also means not having a
println. I decided to go ahead and favor ergonomics and instead be very explicit in the documentation about this