Conversation
fcb3d0c to
5e4f902
Compare
|
cc @Emilgardis |
|
✌️ burrbull can now approve this pull request. To approve and merge a pull request, simply reply with |
adamgreig
left a comment
There was a problem hiding this comment.
LGTM. Maybe worth fixing the clippy lint about the return Some(min..=max);?
I also think the max.wrapping_sub(min) could just be (max - min) since it can't ever underflow, but it doesn't really matter here.
bors d+
5e4f902 to
980ae4c
Compare
|
Fixed. |
|
👎 Rejected by too few approved reviews |
adamgreig
left a comment
There was a problem hiding this comment.
hah, what use is bors delegating if as soon as you push a commit it revokes approval?
bors r+
|
Build succeeded: |
Yeah, need to change the configuration to not dismiss a review after a new commit. |
|
I'm all for it, especially for projects with little risk of abuse (like sneaking in changes after approval of unmergeable PRs). However we'd have to be more permissive in our rules: https://github.com/rust-embedded/wg/blob/master/ops/post-transfer.md#repository-settings |

cc @adamgreig
Partially related to stm32-rs/stm32-rs#701 (comment)