Conversation
|
r? @adamgreig (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
adamgreig
previously approved these changes
Apr 14, 2021
Member
adamgreig
left a comment
adamgreig
left a comment
There was a problem hiding this comment.
LGTM. Successfully generated some STM32 PACs using 0.18 which build and run in a simple example.
Closed
therealprof
force-pushed
the
0.18
branch
2 times, most recently
from
2e69dee to
d230e9d
Compare
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
burrbull
approved these changes
Apr 17, 2021
Member
|
bors r+ |
Contributor
Contributor
Author
|
... and published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? adamgreig
Signed-off-by: Daniel Egger daniel@eggers-club.de