Update clap requirement from 2.34.0 to 3.0.1#10253
Conversation
Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_generate-v3.0.0-rc.0...clap_complete-v3.0.1) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
Are there any thoughts on whether to port immediately or wait? I'd be willing to port cargo, just double checking that it is wanted at this time. |
|
I am one vote among several, but I would be happy to have you do the update! |
|
I think it'd be good to upgrade yeah, but Cargo's pretty big and this is probably a big update so we'll likely want to pay special attention to any changes in |
|
Yes, I am especially concerned about the unenumerated parser changes that happened before I took over (clap-rs/clap#3249 being an example that doesn't impact cargo) |
|
Superseded by #10259. |
|
As an update, I've now got this down to a debug assert during |
Updates the requirements on clap to permit the latest version.
Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
... (truncated)
Commits
d392b88chore: Release1a19d48docs: Update changelog3782d8eMerge pull request #3247 from epage/len5c829ffMerge pull request #3246 from epage/warne580683fix: Don't panic when getting number of values6b9ae54fix(derive): Don't enit warningsb0cb205docs(derive): Include name magic attribute06f24b1Merge pull request #3243 from intgr/fix-clap_complete-documentation-importsf10c5d1docs(complete): Fix imports in documentation879219aMerge pull request #3240 from epage/heckDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)