refactor(progress): Make the code more approachable#16813
Merged
weihanglo merged 5 commits intorust-lang:masterfrom Mar 31, 2026
Merged
refactor(progress): Make the code more approachable#16813weihanglo merged 5 commits intorust-lang:masterfrom
weihanglo merged 5 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-console-output
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
Mar 31, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 2, 2026
Update cargo submodule 12 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..0c7d80bf5ad3b873a5dbf44e0185152890c6d18a 2026-03-30 16:59:25 +0000 to 2026-04-02 20:48:06 +0000 - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809) r? ghost
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 3, 2026
Update cargo submodule 15 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..a357df4c26fc14514e66aae2a269456b5545c7db 2026-03-30 16:59:25 +0000 to 2026-04-03 16:47:15 +0000 - chore: downgrade to libz-sys@1.1.24 (rust-lang/cargo#16833) - feat: add frame-pointers profile option (rust-lang/cargo#16742) - upgrade to gix@0.81.0 (rust-lang/cargo#16828) - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809)
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 4, 2026
Update cargo submodule 15 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..a357df4c26fc14514e66aae2a269456b5545c7db 2026-03-30 16:59:25 +0000 to 2026-04-03 16:47:15 +0000 - chore: downgrade to libz-sys@1.1.24 (rust-lang/cargo#16833) - feat: add frame-pointers profile option (rust-lang/cargo#16742) - upgrade to gix@0.81.0 (rust-lang/cargo#16828) - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809)
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 4, 2026
Update cargo submodule 15 commits in 888f675344eb1cf2308fd53183e667bdd2c58e51..a357df4c26fc14514e66aae2a269456b5545c7db 2026-03-30 16:59:25 +0000 to 2026-04-03 16:47:15 +0000 - chore: downgrade to libz-sys@1.1.24 (rust-lang/cargo#16833) - feat: add frame-pointers profile option (rust-lang/cargo#16742) - upgrade to gix@0.81.0 (rust-lang/cargo#16828) - refactor(network): use async for registry network operations (rust-lang/cargo#16745) - fix(compile): Don't hide hard warnings with build.warnings=allow (rust-lang/cargo#16827) - chore: Upgrade incompatible dependencies (rust-lang/cargo#16825) - fix(compile): build.warnings=allow should not hide denied diagnostics (rust-lang/cargo#16824) - fix(install): Ignore resolver.lockfile-path (rust-lang/cargo#16823) - chore(deps): update compatible (rust-lang/cargo#16820) - refactor(compile): Consolidate output options (rust-lang/cargo#16821) - refactor: Export public dependencies from internal crates (rust-lang/cargo#16819) - refactor(progress): Make the code more approachable (rust-lang/cargo#16813) - Simplified build script bin names in new layout (rust-lang/cargo#16812) - fix: set CARGO env var during rustc -vV probe (rust-lang/cargo#16811) - Split out `cargo-util-terminal` (rust-lang/cargo#16809)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This applies the principles from https://epage.github.io/dev/rust-style/ as well as pulls up the use of
gctx/Shell.My hope was to decouple progress from
gctxcompletely so it can go incargo-util-terminalbut there isimpl Drop for Progressand I've paused that effort for now. I still feel these cleanups are worth merging on their own. In particular, eachshell()call grabs and releases the lock for it and now we only grab it at the highest levels of operations, reducing the chance for race conditions and speeding things up (but will it be noticed?).How to test and review this PR?