Skip to content

Send Content-Type header with cargo publish requests#16832

Open
dralley wants to merge 1 commit intorust-lang:masterfrom
dralley:fixes
Open

Send Content-Type header with cargo publish requests#16832
dralley wants to merge 1 commit intorust-lang:masterfrom
dralley:fixes

Conversation

@dralley
Copy link
Copy Markdown

@dralley dralley commented Apr 3, 2026

What does this PR try to resolve?

Sends an appropriate Content-Type header with cargo publish requests.

Resolves:

#16830

How to test and review this PR?

If necessary, find a way to log the request headers / metadata - I tested this against my in-progress registry implementation. Maybe there is logging mode which can skip that step, I'm not sure.

@rustbot rustbot added A-interacts-with-crates.io Area: interaction with registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 3, 2026

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

@dralley dralley changed the title Fixes two issues that make writing Fixes two issues that help third party registries Apr 3, 2026
@dralley dralley changed the title Fixes two issues that help third party registries Fixes two issues that unnecessarily complicate third party registry implementations Apr 3, 2026
@epage
Copy link
Copy Markdown
Contributor

epage commented Apr 3, 2026

Note that our contrib guide asks for Issues to be tagged S-accepted before moving onto PRs.

In addition, this would best be handled with separate PRs because

  • They are unrelated
  • They have different compatibility considerations and on or more might need team sign off with an FCP

@dralley
Copy link
Copy Markdown
Author

dralley commented Apr 3, 2026

Ok, I can split into two PRs. Apologies.

And I will wait before filing a PR for the other issue.

@dralley dralley changed the title Fixes two issues that unnecessarily complicate third party registry implementations Send Content-Type header with cargo publish requests Apr 3, 2026
@rustbot

This comment has been minimized.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 3, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16830 (comment)

Would you mind also updating docs?

I guess we can instead specify content-type in each API respectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-interacts-with-crates.io Area: interaction with registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants