Send Content-Type header with cargo publish requests#16832
Send Content-Type header with cargo publish requests#16832dralley wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Note that our contrib guide asks for Issues to be tagged In addition, this would best be handled with separate PRs because
|
|
Ok, I can split into two PRs. Apologies. And I will wait before filing a PR for the other issue. |
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
Would you mind also updating docs?
I guess we can instead specify content-type in each API respectively
What does this PR try to resolve?
Sends an appropriate
Content-Typeheader withcargo publishrequests.Resolves:
#16830
How to test and review this PR?
If necessary, find a way to log the request headers / metadata - I tested this against my in-progress registry implementation. Maybe there is logging mode which can skip that step, I'm not sure.