Remove non-inline modules in blocks#2384
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| macro_rules! declare_mod { | ||
| ($name:ident) => ( pub mod $name; ) | ||
| } | ||
| each_subcommand!(declare_mod); |
There was a problem hiding this comment.
Weird, I'm kinda surprised that this doesn't require the path to the source file to be src/bin/subcommands/foo.rs...
There was a problem hiding this comment.
Yeah, it should require that. Right now, macro-expanded non-inline module declarations are always treated as if they were at the file root due to a bug in the macro expander.
|
Also for onlookers, this is to ward of the upcoming breakage of rust-lang/rust#31534 |
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
4 participants
r? @alexcrichton