Skip to content

Allow unused keys starting with cargo-#2761

Closed
pwoolcoc wants to merge 1 commit into
rust-lang:masterfrom
pwoolcoc:dont-warn-unused-keys-for-cargo-subcommands
Closed

Allow unused keys starting with cargo-#2761
pwoolcoc wants to merge 1 commit into
rust-lang:masterfrom
pwoolcoc:dont-warn-unused-keys-for-cargo-subcommands

Conversation

@pwoolcoc

@pwoolcoc pwoolcoc commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

This change would make it so that cargo does not warn about "unused
keys" for keys that start with cargo-. This could be useful for custom
subcommands that want to be able to read settings from Cargo.toml.

This change would make it so that cargo does not warn about "unused
keys" for keys that start with `cargo-`. This could be useful for custom
subcommands that want to be able to read settings from `Cargo.toml`.
@rust-highfive

Copy link
Copy Markdown

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@pwoolcoc pwoolcoc changed the title Allow unused keys starting with ``cargo-'' Allow unused keys starting with cargo- Jun 1, 2016
@jonas-schievink

Copy link
Copy Markdown
Contributor

#2668 implements a similar approach

@alexcrichton

Copy link
Copy Markdown
Member

Thanks for the PR! Talking about this in the past, however, we've preferred the approach in #2668 to this. Would that suffice for your use case?

@pwoolcoc

pwoolcoc commented Jun 2, 2016

Copy link
Copy Markdown
Contributor Author

Ah, sorry I hadn't seen that! That will be fine, sorry for the unnecessary PR

@pwoolcoc pwoolcoc closed this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants