Lowercase and remove periods in error messages for consistency

[camelid]

No description provided.

[rust-highfive]

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

[camelid]

Will this cause rustc tests to fail?

[camelid]

I ran:

$ fgrep 'Could not document' -r src/test

in rust-lang/rust and nothing came up, so I assume that there are no rustc tests that would be affected.

[camelid]

It looks like there are a few more error messages that start with an uppercase letter and/or end with a period.

[camelid]

E.g.:

$ grep '"Could not .*"' -r src
src/cargo/util/important_paths.rs:        anyhow::bail!("Could not find `{}` in `{}`", file, pwd.display())
src/cargo/util/process_builder.rs:                return Err(process_error("Could not set Ctrl-C handler.", None, None).into());
src/cargo/ops/cargo_read_manifest.rs:                "Could not find Cargo.toml in `{}`",

[ehuss]

Looks like there are some tests that need to be updated.

If you want to update those other error messages, that would be fine, up to you!

[camelid]

Is there any equivalent of ./x.py test --bless that I can use here?

[camelid]

What should I do about this message?

cargo/src/cargo/core/workspace.rs

Lines 155 to 158 in 99134ae

	anyhow::bail!(
	"manifest_path:{:?} is not an absolute path. Please provide an absolute path.",
	manifest_path
	)

[camelid]

It looks like there are a ton of error messages that need to be updated (around 40, by my estimate), so it might not be worth it for now ;)

I think I'll stick with only updating the overall "could not document" messages.

[ehuss]

Is there any equivalent of ./x.py test --bless that I can use here?

Unfortunately there is not.

What should I do about this message?

The message is probably OK, I believe it is only for library users anyways.

I think I'll stick with only updating the overall "could not document" messages.

That's totally fine!

[camelid]

CI should hopefully pass now!

[camelid]

Okay, all tests are updated and CI is passing!

[ehuss]

Thanks!

@bors r+

[bors]

📌 Commit a9424d9 has been approved by ehuss

[camelid]

Hmm, I wonder why bors isn't testing. There aren't any PRs ahead of this one in the queue:

[ehuss]

@bors r+

[bors]

📌 Commit 82c834c has been approved by ehuss

[bors]

⌛ Testing commit 82c834c with merge 875e012...

[camelid]

Now it's working! Thanks :)

[ehuss]

Yea, I think the bot was recently restarted, and it sometimes gets confused when that happens.

[camelid]

bors has been a bit sluggish recently on other things too.

[bors]

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 875e012 to master...