Closed
Conversation
This also updates the docs.rs codebase to account for this cargo change: rust-lang/cargo#7186
Contributor
|
Is this necessary, now that #407 is merged? |
Member
Author
|
Hmm, cargo is still used in other parts of docs.rs, so this might still be useful. I'll rebase it when I have some spare time. |
Contributor
|
Also please be aware that pushing cargo all the way to master might be counterproductive, if it's not the same commit that the rust compiler is using. Double-check that the commit you eventually rebase with is the same that the submodule on rust-lang/rust is at. |
Member
|
This is obsoleted by #461. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates the docs.rs codebase to account for this cargo change. Should fix regex 1.3.0 failing to build once a build is rescheduled with this.