This repository was archived by the owner on Mar 14, 2023. It is now read-only.
link cargo to its CONTRIBUTING.md#132
Merged
nrc merged 1 commit intorust-lang:masterfrom Apr 12, 2018
dwijnand:cargo-contributing
Merged
link cargo to its CONTRIBUTING.md#132nrc merged 1 commit intorust-lang:masterfrom dwijnand:cargo-contributing
nrc merged 1 commit intorust-lang:masterfrom
dwijnand:cargo-contributing
Conversation
Member
|
Heh, I have literally no idea whether this will work! This is a feature from Servo highfive that we don't use. However, it looks like it should work, so let's give it a go! |
Contributor
Author
|
assuming this change is what is running, it looks like it didn't work :( |
Collaborator
|
I suspect your change has not been deployed. This is what happens on master: |
Member
|
I deployed just now (I tend to batch changes and deploy once per week or so), so the next PR to Cargo should see this change |
Contributor
Author
|
confirmed! 🎉 rust-lang/cargo#5402 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note this is just from a quick look at the code and the README - I'm not sure if this is right, so feedback very welcome.