Add IOV_MAX and UIO_MAXIOV constants#1880
Merged
JohnTitor merged 1 commit intorust-lang:masterfrom Sep 2, 2020
Thomasdezeeuw:io-max-consts
Merged
Add IOV_MAX and UIO_MAXIOV constants#1880JohnTitor merged 1 commit intorust-lang:masterfrom Thomasdezeeuw:io-max-consts
JohnTitor merged 1 commit intorust-lang:masterfrom
Thomasdezeeuw:io-max-consts
Conversation
These constant can be used to determine the maximum number of iovecs can be passed to functions like readv/writev. Linux like uses UIO_MAXIOV, while the BSD family uses IOV_MAX.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Contributor
Author
|
I don't know how to add tests for these constants. I also couldn't run the tests locally as it failed with a huge list of errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constant can be used to determine the maximum number of iovecs can
be passed to functions like readv/writev.
Linux like uses UIO_MAXIOV, while the BSD family uses IOV_MAX.