Merged
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
no1wudi
force-pushed
the
main
branch
3 times, most recently
from
ada89af to
e0f533d
Compare
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
ba0058f to
4c9905f
Compare
Contributor
|
☔ The latest upstream changes (presumably #3866) made this pull request unmergeable. Please resolve the merge conflicts. |
no1wudi
force-pushed
the
main
branch
3 times, most recently
from
12f1663 to
300cd25
Compare
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
c0aab43 to
1699862
Compare
Define the essential types that for NuttX OS. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Contributor
|
I didn't read through everything thoroughly but since this is a tier3 target and you are the maintainer, I'll take your word for it :). Based on your links it seems like the exact API may need some development, but you can update as needed. @rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 25, 2024
Initial std library support for NuttX This PR add the initial libstd support for NuttX platform (Tier 3), currently it depends on rust-lang/libc#3909 which provide the essential libc definitions.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2024
Rollup merge of rust-lang#130595 - no1wudi:master, r=ibraheemdev Initial std library support for NuttX This PR add the initial libstd support for NuttX platform (Tier 3), currently it depends on rust-lang/libc#3909 which provide the essential libc definitions.
no1wudi
added a commit
to no1wudi/libc
that referenced
this pull request
Oct 10, 2024
Define the essential types that for NuttX OS. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
3 tasks
no1wudi
added a commit
to no1wudi/libc
that referenced
this pull request
Oct 10, 2024
Define the essential types that for NuttX OS. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Oct 15, 2024
Define the essential types that for NuttX OS. Signed-off-by: Huang Qi <huangqi3@xiaomi.com> (backport <rust-lang#3909>) (cherry picked from commit c31dfc1)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Oct 15, 2024
Define the essential types that for NuttX OS. Signed-off-by: Huang Qi <huangqi3@xiaomi.com> (backport <rust-lang#3909>) (cherry picked from commit c31dfc1)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the essential types that for NuttX OS.
NuttX has beed added to Rust by rust-lang/rust#127755, this patch is try to introduce basic libc support for NuttX, see the discussion in NuttX community:
apache/nuttx#12960
apache/nuttx#13245