Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
Some changes occurred in the Android module cc @maurer |
|
Left a couple comments, please also the debug changes from #4229 (review). You can probably just find+replace those |
fea746a to
b86d2d6
Compare
Ok I think this one is good to go now as well. No rush, just wanted to lyk. Please let me know if any other changes are needed. |
(backport <rust-lang#4230>) (cherry picked from commit 174a37c)
Description
Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI