Fix SUMMARY's parse_numbered with comment#1167
Merged
Merged
Conversation
ehuss
reviewed
Mar 17, 2020
Comment on lines
380
to
382
Contributor
There was a problem hiding this comment.
Thanks! Can you add a comment here explaining why it is doing this?
Contributor
Author
There was a problem hiding this comment.
Thanks!
I added a comment.
dalance
force-pushed
the
fix_summary_comment
branch
from
6c4d0c2 to
b82562f
Compare
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Fix SUMMARY's parse_numbered with comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1096.
If
SUMMARYcontains comment like below:- [Second]generateEvent::Start(Tag::List(..)), butitemsis empty because it is not nested.The empty can be ignored.