Fix relative paths for renderer commands.#1418
Merged
Merged
Conversation
Contributor
Author
|
Note to self: The preprocessor custom command is relative to the current directory, but it should be relative to the book root. Unfortunately the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom renderers that explicitly set the
commandto a relative path was using the wrong base path. On Windows, it was relative to the current directory, and on Unix it was relative to the renderer output directory (see rust-lang/rust#37868 for this unfortunate behavior). Neither are correct, they should be relative to the book root. This changes it so that it is relative to the book root, and has a legacy warning for the old behavior of relative to the output directory. This uses absolute paths to avoid problems withcurrent_dir().