Revert "book: use non_exhaustive attribute for struct Book"#1572
Merged
ehuss merged 1 commit intoJun 8, 2021
Merged
Conversation
This reverts commit c1b2bec.
|
Would it make sense to revert the commit on v0.4.9 directly, yank 0.4.9 and publish 0.4.10 with the revert as only difference? |
Contributor
Author
Possibly, yeah. I just did this quickly because I was already in there, but I'll let @ehuss decide the right way to handle it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c1b2bec due to a breaking change.
Fixes #1571.
See #1557.