feat: keyboard shortcut to toggle sidebar#2343
Conversation
hirehamir
left a comment
There was a problem hiding this comment.
I would have liked to do this in https://github.com/rust-lang/mdBook/blob/master/src/theme/book.js#L443, but for some reason this keyboard shortcut wasn't working there, while the click handler worked without issue.
|
@Dylan-DPC I tried to do this in a cleaner way with hirehamir@a7da1d0, but |
This comment has been minimized.
This comment has been minimized.
1d44c61 to
1dda4d3
Compare
1dda4d3 to
e744bc2
Compare
With this changeWith this pull request, users would be able to collapse, and expand, the sidebar with just their keyboard. 2025-05-10_15.59.49.mp4 |
|
@ehuss are there any changes you'd like me to make here? I fixed the merge conflicts. It's been around 414 days or so since I opened this pull request. I'm hoping we can get it across the finish line. |
|
@y21 would you happen to know how I can get feedback from I think this feature could make life easier for a lot of |
|
Sorry, I don't know about the reviewing process in this repo here, usually (at least in clippy and the Rust repo) the standard wait time is 14 days, at which point a reviewer can be rerolled with This does look like a useful feature though 👍 |
|
☔ The latest upstream changes (possibly 21f2435) made this pull request unmergeable. Please resolve the merge conflicts. |
closes #2342.