Upgrade pulldown cmark to 0.13.0#2401
Merged
Merged
Conversation
chriskrycho
added a commit
to rust-lang/book
that referenced
this pull request
Jul 22, 2024
Needs rust-lang/mdBook#2401 to land before it can be landed, because mdbook requires pulldown-cmark 0.10, so there is a type mismatch on `Event`: ``` error[E0271]: expected `Parser<'_>` to be an iterator that yields `Event<'_>`, but it yields `Event<'_>` --> src/lib.rs:372:39 | 372 | html::push_html(&mut buf, events); | --------------- ^^^^^^ expected `Event<'_>`, found `pulldown_cmark::Event<'_>` | | | required by a bound introduced by this call | = note: `pulldown_cmark::Event<'_>` and `Event<'_>` have similar names, but are actually distinct types note: `pulldown_cmark::Event<'_>` is defined in crate `pulldown_cmark` --> /Users/chris/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pulldown-cmark-0.10.3/src/lib.rs:354:1 | 354 | pub enum Event<'a> { | ^^^^^^^^^^^^^^^^^^ note: `Event<'_>` is defined in crate `pulldown_cmark` --> /Users/chris/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pulldown-cmark-0.11.0/src/lib.rs:366:1 | 366 | pub enum Event<'a> { | ^^^^^^^^^^^^^^^^^^ = note: perhaps two different versions of crate `pulldown_cmark` are being used? ```
This was referenced Jul 22, 2024
Contributor
Author
|
Sorry for the ping @ehuss, but from a glance at latest commits it seem you're in charge of PRs.
|
Contributor
|
As the comment says, we can't update it at this time. See #2387. We will likely update this when we do a 0.5 release. |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
CI fails on minimum MSRV, so holding back and waiting for guidance here :) |
This comment has been minimized.
This comment has been minimized.
ehuss
force-pushed
the
chore/upgrade-pulldown-cmark
branch
from
d63e9be to
95b5631
Compare
ehuss
force-pushed
the
chore/upgrade-pulldown-cmark
branch
from
95b5631 to
91f04bc
Compare
ehuss
approved these changes
Jul 26, 2025
Contributor
ehuss
left a comment
ehuss
left a comment
There was a problem hiding this comment.
Thanks, I have update it to 0.13.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi and thanks for this beautiful piece of tooling, I simply love it since the first time I discovered it!
I updated
pulldown-cmarkbut noticed the comment saying not to inCargo.toml, so feel free to dismiss this PR if this is not supposed to happen from an external contribution.If however you do accept this PR, I'd like to add a mathematical expression to the tests for the sake of completeness but I'd appreciate that you point me which markdown is the most appropriate, so putting this under draft for now.
Thanks!