Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of directly writing html from Rust, use a Handlebars template to generate the table of contents. This requires build a separate json object from
chapters. To remove the duplicated data, the second commit adapts navigation to use the newtocjson object instead, and is an alternative to #465.Pros:
Cons:
I'm not quite sure how to organise the code. Perhaps
toc_json.rscould be merged withhelpers/toc.rs. I'm also not sure when to trust the code and useunwrapand when passing along errors is preferred.#458