fix: Insert spaces when inlining a function defined in a macro.#12877
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 26, 2022
Merged
fix: Insert spaces when inlining a function defined in a macro.#12877bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
zachs18
commented
Jul 25, 2022
Member
|
Thanks! I think the FIXME comment can just go |
Contributor
|
✌️ @zachs18 can now approve this pull request |
Contributor
Author
|
Okay, I removed the FIXME comment. Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(partially) fixes #12860.
This PR (only) addresses the whitespace issue when inlining functions defined in macros.
Additionally, the indentation/spacing is not ideal, but works, e.g.
The
self->thisproblem1 is (probably?) a separate problem that I am also looking into.Footnotes
As mentioned in my comment on the above issue, inlining a method defined in a macro does not properly replace
selfwith the new localthis. ↩