fix: use ExprIsRead::Yes for rhs of ordinary assignments#21649
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Feb 15, 2026
Merged
Conversation
the rhs of an ordinary assignment `x = *never_ptr` was inferred with `ExprIsRead::No`, which prevented `NeverToAny` coercion for place expressions of type `!`. this caused false type mismatches and missing divergence detection. the destructuring assignment path and let binding path both correctly use `ExprIsRead::Yes` for the rhs value, since the value is always consumed (read). this makes the ordinary assignment path consistent with both.
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Feb 15, 2026
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
True, the RHS of an assignment does constitute read (the LHS does not).
Thanks!
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the rhs of an ordinary assignment
x = *never_ptrwas inferred withExprIsRead::No, which preventedNeverToAnycoercion for place expressions of type!. this caused false type mismatches and missing divergence detection. the destructuring assignment path and let binding path both correctly useExprIsRead::Yesfor the rhs value, since the value is always consumed (read). this makes the ordinary assignment path consistent with both.