feat: add diagnostic for E0529#22334
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom May 10, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
May 10, 2026
WaterWhisperer
force-pushed
the
diag-array-slice-pat
branch
from
ec41883 to
b9600b6
Compare
ChayimFriedman2
requested changes
May 10, 2026
WaterWhisperer
force-pushed
the
diag-array-slice-pat
branch
from
b9600b6 to
6012557
Compare
ChayimFriedman2
requested changes
May 10, 2026
| } | ||
| Pat::Slice { prefix, slice, suffix } => { | ||
| // FIXME: MIR lowering should be skipped for bodies with inference errors. Otherwise | ||
| // invalid slice patterns can reach this code with an error type. |
Contributor
There was a problem hiding this comment.
I meant, still put the if, we need the tests after all, but also put the FIXME to remove it when we no longer lower MIR with errors.
Contributor
Author
There was a problem hiding this comment.
Oh, sorry for misunderstanding
Contributor
|
Ignore the CI failure; it happens sporadically (we need to figure out why). |
WaterWhisperer
changed the title
WaterWhisperer
force-pushed
the
diag-array-slice-pat
branch
from
6012557 to
6c46dc6
Compare
ChayimFriedman2
approved these changes
May 10, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #22140