CI: replace cancel-outdated-builds with concurrency group#12477
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Member
|
@bors r+ Thanks! There are no blockers on this from the Clippy side, so I don't think we have to wait for / bother Mark with this. |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Mar 14, 2024
CI: replace `cancel-outdated-builds` with `concurrency` group This is the last remaining [usage](https://github.com/search?q=org%3Arust-lang%20cancel-outdated-builds&type=code) of the [cancel-outdated-builds](https://github.com/rust-lang/simpleinfra/tree/master/github-actions/cancel-outdated-builds) CI action. Which means that if we remove its usage, we can remove the code of the action :) This action was replaced in `rust-lang/rust` with the native Github Actions `concurrency` group [last year](rust-lang/rust#112955). Note that unlike `rust-lang/rust`, which explicitly allows parallel try builds, `clippy` did not allow them, as all steps of the `clippy_bors.yaml` workflow used the `cancel-outdated-builds` action, regardless of the branch. So the new `concurrency` group mirrors that, which makes it a bit simpler than on `rust-lang/rust`. r? `@Mark-Simulacrum`
Contributor
|
💔 Test failed - checks-action_test |
Member
Author
|
Added changelog (didn't know it's required). |
Member
|
We need a changelog line, but if it is just an internal change, @bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last remaining usage of the cancel-outdated-builds CI action. Which means that if we remove its usage, we can remove the code of the action :)
This action was replaced in
rust-lang/rustwith the native Github Actionsconcurrencygroup last year.Note that unlike
rust-lang/rust, which explicitly allows parallel try builds,clippydid not allow them, as all steps of theclippy_bors.yamlworkflow used thecancel-outdated-buildsaction, regardless of the branch. So the newconcurrencygroup mirrors that, which makes it a bit simpler than onrust-lang/rust.changelog: none
r? @Mark-Simulacrum