Skip to content

Fix useless_attribute FP on deprecated_in_future#15645

Merged
y21 merged 1 commit intorust-lang:masterfrom
profetia:issue15636
Sep 11, 2025
Merged

Fix useless_attribute FP on deprecated_in_future#15645
y21 merged 1 commit intorust-lang:masterfrom
profetia:issue15636

Conversation

@profetia
Copy link
Member

@profetia profetia commented Sep 9, 2025

Closes #15636

changelog: [useless_attribute] fix FP on deprecated_in_future

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jhpratt
Copy link
Member

jhpratt commented Sep 10, 2025

Not a clippy reviewer, but LGTM.

Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y21 y21 added this pull request to the merge queue Sep 11, 2025
Merged via the queue into rust-lang:master with commit ec73197 Sep 11, 2025
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2025
@profetia profetia deleted the issue15636 branch January 24, 2026 20:56
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2026
…tributes (#16470)

The `exported_private_dependencies` lint can fire on any mention of an
item from a private dependency, including mentions inside of `use`.
Therefore, `useless_attribute` should not fire on lint attributes
mentioning `exported_private_dependencies` attached to a `use`.

changelog: [`useless_attribute`]: fix false positive on
`exported_private_dependencies` lint attributes

PR #15645 was used as an example for preparing this
PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useless_attribute does not understand deprecated_in_future properly

4 participants