Allow Box<[JsValue]> parameter type

[rivertam]

changelog: Don't warn boxed_local for unsized
fixes #4351

[flip1995]

IMO this function is clearer if you just write ty.is_box() && !ty.boxed_ty().is_sized(..)

Everything else LGTM.

[ghost]

I don't think this fixes the issue. The code changed relates to the unstable box keyword. Boxes in parameters should still be linted with this which was mentioned in the issue. (I haven't actually tested this but there isn't a test for it either.)

[flip1995]

Good catch. I also think, that #4351 (comment) is the right solution.

[rivertam]

I'm trying to implement this as we discussed in the issue, but I'm struggling on how to check if the boxed type is a [wasm_bindgen::JsValue]. I imagine we could use ty.boxed_ty().same_type(js_array_value_ty), but I don't know how to construct js_array_value_ty. Open to other approaches, but this is the only particularly helpful method I'm seeing on Ty.

[flip1995]

JsValue has probably ty::TyKind::Path(qpath).

You can add the whole path of the JsValue (the whole path not the path of the reexport if it is a reexport) to utils::paths and then use the function utils::match_qpath to check if it's the type.

[bors]

☔ The latest upstream changes (presumably #4591) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

Thanks for contributing to Clippy! Sadly this PR was not updated in quite some time. If you waited on input from a reviewer, we're sorry that this fell under the radar. If you want to continue to work on this, just reopen the PR and/or ping a reviewer.