Merged
Conversation
flip1995
added
the
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #4591) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
force-pushed
the
ice_4579
branch
2 times, most recently
from
30eaee0 to
d8a9d6e
Compare
Member
|
@bors r+ |
Contributor
|
📌 Commit d8a9d6e has been approved by |
Contributor
Contributor
|
💔 Test failed - status-appveyor |
Contributor
|
@bors retryr |
Contributor
|
@bors retry (good morning 🌅 ) |
Contributor
Contributor
|
💔 Test failed - checks-travis |
Contributor
|
needs a rebase, then it should be good to go |
phansch
added
S-waiting-on-author
Member
|
Integration tests won't pass because of Rust bug. |
Member
|
Feel free to mark those as allowed fail, I don't think that rust bug is
going to be fixed within the next few days, seems tricky.
…On Tue, Oct 1, 2019, 11:56 PM Mateusz Mikuła ***@***.***> wrote:
Integration tests won't pass because of Rust bug.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4590?email_source=notifications&email_token=AAMK6SDR5ZPOH3VHZWBBCNLQMRA2XA5CNFSM4I3GR57KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADYDNI#issuecomment-537362869>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMK6SFICHATUS7MJPLYREDQMRA2XANCNFSM4I3GR57A>
.
|
Member
Author
|
Rebased seemed to be enough @bors r=Manishearth |
Contributor
|
📌 Commit 93bda48 has been approved by |
Contributor
Contributor
|
💔 Test failed - checks-travis |
Member
Author
Ups should have read the comments more carefully 😄 @bors r=Manishearth |
Contributor
|
📌 Commit eb1fc7b has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Closed
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Oct 11, 2019
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 15, 2019
[Beta] Backport Clippy ICE fix to beta There was an ICE in Clippy, when compiling `mysql_common`. Since this is a pretty popular crate, and there were a bunch of Clippy issues in the last few days, I think it is worth it to backport the fix (rust-lang/rust-clippy#4590) to beta. cc rust-lang/rust-clippy#4653 r? @Manishearth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4579
Fixes #4584
r? @phansch
changelog: Fix ICE caused by Clippys const-utils