Merged
Conversation
flip1995
reviewed
Nov 13, 2019
flip1995
reviewed
Nov 13, 2019
flip1995
reviewed
Nov 13, 2019
flip1995
approved these changes
Nov 13, 2019
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
LGTM now. I would merge this as is and do the hard part in a new PR. Please squash some commits first, though.
basil-cow
force-pushed
the
large_stack_arrays
branch
from
f4c7ca5 to
8648e3d
Compare
Contributor
Author
|
Did I do it right? |
Member
|
Kind of. It is squashed, but you should adapt the commit message. You can do this with |
added documentation minor style fix change as to ::from add ignore to doc include threshold in lint message/make suggestion more apparent/use Scalar api instead of matching style fix shange snippet_opt to snippet
basil-cow
force-pushed
the
large_stack_arrays
branch
from
8648e3d to
7fddac0
Compare
basil-cow
changed the title
large_stack_arrays lintlarge_stack_arrays lint
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 4 Pull requests with new lints Rollup of pull requests - #4816 (New lint: zst_offset) - #4814 (New lint: Implement ifs_same_cond_fn) - #4807 (Add `large_stack_arrays` lint) - #4806 (Issue/4623) changelog: add [`zst_offset`] lint changelog: New lint: [`ifs_same_cond_fn`] cahngelog: Add new lint [large_stack_arrays] changelog: added lint [`tabs_in_doc_comments`]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like some feedback for the easy version before doing the more hard one, tracking issue: #4520
changelog: Add new lint [
large_stack_arrays]