add from_raw_with_void_ptr lint#9690
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 23, 2022
roynrishingha:boxed_void
Merged
add from_raw_with_void_ptr lint#9690bors merged 1 commit intorust-lang:masterfrom roynrishingha:boxed_void
from_raw_with_void_ptr lint#9690bors merged 1 commit intorust-lang:masterfrom
roynrishingha:boxed_void
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
requested changes
Oct 23, 2022
kraktus
reviewed
Oct 23, 2022
flip1995
reviewed
Oct 23, 2022
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
The impl LGTM now. But this lint could potentially also apply to Rc Arc and Weak, not only box. This can also be done in a future PR though, so I don't want to block this PR on it. However, I would chose the lint name, so that applying this lint to other types is possible in the future.
Possible names:
from_raw_with_void_ptrfrom_raw_from_void_ptr- ...? Better ideas?
roynrishingha
changed the title
raw_box_from_void_ptr lintfrom_raw_with_void_ptr lint
roynrishingha
requested review from
flip1995 and
llogiq
and removed request for
flip1995 and
llogiq
Contributor
Author
|
@flip1995 is the PR okay now ? Please let me know. |
flip1995
reviewed
Oct 23, 2022
flip1995
reviewed
Oct 23, 2022
flip1995
approved these changes
Oct 23, 2022
Member
|
@bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
fixes #9679.stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmtchangelog: [
from_raw_with_void_ptr]: added new lint