Skip to content

Determine whether we need a node ID when resolving methods #4951

Closed

Description

@catamorphism

See FIXME (formerly XXX) in the item_trait case in resolve::resolve_item.

Activity

  1. msullivan commented on Jul 1, 2013

    @msullivan
    Contributor

    FIXME still there. We probably don't need a node_id, if it actually works...

  2. emberian commented on Aug 19, 2013

    @emberian
    Contributor
  3. huonw commented on Nov 10, 2013

    @huonw
    Contributor

    Triage: FIXME is still there. I guess having a NodeId would make other tooling easier, e.g. #8961 would likely be easier to fix if every method had an associated NodeId (since it would then not require (as much) special casing).

  4. steveklabnik commented on Aug 12, 2014

    @steveklabnik
    Contributor

    For future spelunkers, this is talking about

    // FIXME #4951: Do we need a node ID here?

  5. added a commit that references this issue on Jul 8, 2015
    80f9d93
  6. added a commit that references this issue on Apr 12, 2026
  7. added a commit that references this issue on Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions