resolve: mark binding is determined after all macros had been expanded

[bvanjoi]

Fixes #113834
Fixes #115377

r? @petrochenkov

[bvanjoi]

ci is failed, thus mark it as draft

[bvanjoi]

reduced for #115269 (comment):

// compile-flags: --edition 2021
// check-pass

macro_rules! types {
    () => {};
}

mod x {
    types!();

    mod a {
        macro_rules! m {
            () => {
                "nop"
            };
        }
        pub(crate) use m;
    }

    mod b {
        use crate::x::*;
        use std::arch::asm;

        pub unsafe fn bbbb() {
            asm!(m!());
        }
    }

    pub use self::a::*;
    pub use self::b::*;
}

fn main() {}

[petrochenkov]

I still think it would be nice to make some refactorings mentioned in https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Is.20this.20an.20appropriate.20solution.20for.20issue.20.23113834.3F/near/386775859 before proceeding to further fixes.
(Changing glob_importers to a set can also be included into refactorings.)

[bvanjoi]

I have updated the algorithm as follows: the glob binding is marked as undetermined if there are unexpended macros in its parent module. Then, it is marked as determined once all macros have been expanded. This flag can be used to update the resolution for it.

I think a good refactoring would be factor out this logic and just call something like update_resolution from resolve_glob_import.

I'm not entirely sure if this is what you're seeking, but I think it comes close.

@rustbot ready

[petrochenkov]

@bors try

[petrochenkov]

@bors try

[bvanjoi]

I've added a pre-condition: xxx && import.is_glob() {}

@rustbot ready

[petrochenkov]

@bors r+

[bors]

📌 Commit 9ea0bbd has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9ea0bbd with merge c5d798c...

[bors]

💔 Test failed - checks-actions

[bvanjoi]

I removed this test in #115269 (comment) as there has a similar struct on stdarch

@rustbot ready

[petrochenkov]

@bors r+

[bors]

📌 Commit f153650 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit f153650 with merge 735bb7e...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 735bb7e to master...

[rust-timer]

Finished benchmarking commit (735bb7e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[1.5%, 3.4%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.1%, -2.8%]	2
All ❌✅ (primary)	2.2%	[1.5%, 3.4%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[3.8%, 3.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.201s -> 632.169s (-0.16%)
Artifact size: 318.02 MiB -> 317.92 MiB (-0.03%)